switch to explicit game state & important bug fix & clang format

Previously the code base assumed that there was a single, global game
state which was the implicit target of all actions taken. Looking
ahead at architectural improvements, this has now been (almost
entirely) made explicit and functions take tak_state_p where
necessary (and also where unnecessary).

Two important fixes to actions.c were made:

- Previously when generating the possible stack moves, stack height
overflows (> 15) were not taken into account and this resulted in the
tree search corrupting the board state. Now action search does not
list all legal actions, rather the subset of these encodeable by the
implementation.

- The check for crushing on a stack move was incorrect (too strict),
and this resulted in many legitimate moves being igonored.

Finally, in other changes, weights have also been improved by training
all games instead of some subset for chosen players, and clang-format
was run on the codebase.

1 files changed, 5 insertions, 5 deletions

diff --git a/include/negamax.h b/include/negamax.h
index e491baa..eedb7dd 100644
--- a/include/negamax.h
+++ b/include/negamax.h
@@ -15,12 +15,12 @@
   along with ct. If not, see <https://www.gnu.org/licenses/>.
 */
 
-#include <stdint.h>
 #include <math.h>
+#include <stdint.h>
 
-#include <tak.h>
 #include <actions.h>
 #include <nn1986.h>
+#include <tak.h>
 #include <tt_llcht.h>
 #include <zobrist.h>
 
@@ -33,8 +33,8 @@ extern char negamax_ptn[9];
 extern uint8_t negamax_search_depth;
 
 extern void negamax_display_progress(const uint8_t cur_depth,
-                     const uint8_t init_depth,
-                     const uint32_t length);
+                                     const uint8_t init_depth,
+                                     const uint32_t length);
 
 // ===================================================================
 // Methods
@@ -50,4 +50,4 @@ void negamax_free(void);
  * `negamax_ptn', and return its value. The `negamax_display_progress'
  * function is called on every new square at the top level.
  */
-float negamax_generate(void);
+float negamax_generate(tak_state_p state);