From fb0d0b91bfd45d1911e993ca753d81da5e60f60c Mon Sep 17 00:00:00 2001
From: tslil <tslil@posteo.de>
Date: Sat, 21 Mar 2026 15:10:05 +0000
Subject: fixing evaluation semantics

---
 rprt-engine/src/evaluate.rs | 33 ++++++++++++++++++++++++++++++---
 1 file changed, 30 insertions(+), 3 deletions(-)

(limited to 'rprt-engine/src')

diff --git a/rprt-engine/src/evaluate.rs b/rprt-engine/src/evaluate.rs
index f6fee8a..b23c1be 100644
--- a/rprt-engine/src/evaluate.rs
+++ b/rprt-engine/src/evaluate.rs
@@ -11,6 +11,8 @@ use thiserror::Error;
 pub enum EvaluationError {
     #[error("{0}")]
     SelectionFunctionError(VectoriseError<SFError>),
+    #[error("Invalid right-only application")]
+    IROApplication,
     #[error("Not yet implemented {0}")]
     UnimplementedError(&'static str),
 }
@@ -21,6 +23,10 @@ pub fn evaluate(
     left: Option<Selection>,
     right: Option<Selection>,
 ) -> Result<StateResult, EvaluationError> {
+    if left.is_none() && right.is_some() {
+        return Err(EvaluationError::IROApplication);
+    };
+
     match comp {
         Composite::SelectionFunction {
             func,
@@ -36,8 +42,29 @@ pub fn evaluate(
             Err(EvaluationError::UnimplementedError("text function"))
         }
         Composite::Hook { kind, left, right } => Err(EvaluationError::UnimplementedError("hook")),
-        Composite::Train2 { f, g } => Err(EvaluationError::UnimplementedError("train2")),
-        Composite::Train3 { f, g, h } => Err(EvaluationError::UnimplementedError("train3")),
-        Composite::Group { operations } => Err(EvaluationError::UnimplementedError("group")),
+        Composite::Train2 { f, g } => {
+            let (left, mut state) = evaluate(es, *f, left, right)?;
+            let (sel, more_state) = evaluate(es, *g, Some(left), None)?;
+            state.extend(more_state);
+            Ok((sel, state))
+        }
+        Composite::Train3 { f, g, h } => {
+            let (f_left, mut f_state) = evaluate(es, *f, left.clone(), right.clone())?;
+            let (g_right, h_state) = evaluate(es, *h, left, right)?;
+            let (sel, g_state) = evaluate(es, *g, Some(f_left), Some(g_right))?;
+            f_state.extend(h_state);
+            f_state.extend(g_state);
+            Ok((sel, f_state))
+        }
+        Composite::Group { operations } => {
+            // TODO: does rust have some monadic failure map thing on first failure?
+            let mut selections = Vec::new();
+            let mut states = Vec::new();
+            for f in operations {
+                let (sel, state) = evaluate(es, f, left.clone(), right.clone())?;
+                selections.extend(sel);
+                states.extend(state);
+            }
+        }
     }
 }
-- 
cgit v1.2.3