From d39e9f242d7e71a517adbe003e9b3a25b676a052 Mon Sep 17 00:00:00 2001 From: tslil clingman Date: Tue, 26 Jan 2021 22:23:02 -0500 Subject: Small oversight --- src/ct1986.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ct1986.c b/src/ct1986.c index ca22f15..213f3ff 100644 --- a/src/ct1986.c +++ b/src/ct1986.c @@ -87,10 +87,10 @@ new_game(uint8_t size) { static uint8_t perc; inline void -negamax_display_progress(const uint8_t depth) { +negamax_display_progress(const uint8_t depth, const uint32_t length) { if (depth == 0) { perc++; - lcd_printf_line(L_OVERWRITE, "Computing: %d%%", perc*4); + lcd_printf_line(L_OVERWRITE, "Computing: %d%%", (perc*100)/length); } } -- cgit v1.2.3 From 6b48baaf6b67cc7364d5945eb6d9b25ea9683bd9 Mon Sep 17 00:00:00 2001 From: tslil clingman Date: Tue, 26 Jan 2021 22:39:28 -0500 Subject: Somehting along these lines, i'm tired --- include/actions.c | 25 +++++-------- include/actions.h | 11 ++++++ include/zobrist.c | 104 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ include/zobrist.h | 15 ++++++++ 4 files changed, 138 insertions(+), 17 deletions(-) create mode 100644 include/zobrist.c create mode 100644 include/zobrist.h diff --git a/include/actions.c b/include/actions.c index 9b3534b..96264d0 100644 --- a/include/actions.c +++ b/include/actions.c @@ -8,15 +8,6 @@ #define CLR_STONE NUM_MASK -#define TYPE_SHIFT 24 -#define LOC_SHIFT 16 -#define DATA0_SHIFT 8 - -#define GET_TYPE(a) (enum A_TYPE)((a)>>TYPE_SHIFT) -#define GET_LOC(a) (int8_t)(((a)>>LOC_SHIFT) & 0xFF) -#define GET_DATA0(a) (uint8_t)(((a)>>DATA0_SHIFT) & 0xFF) -#define GET_DATA1(a) (uint8_t)((a) & 0xFF) - static inline void list_append(action_list_t *list, const enum A_TYPE type, const int8_t loc, const uint8_t data0, @@ -65,13 +56,13 @@ void action_list_free(action_list_t *list) { } // Keep track of move offsets -static int8_t deltas[4]; +int8_t move_deltas[4]; void action_list_init(void) { - deltas[0] = +board_size; - deltas[1] = -board_size; - deltas[2] = -1; - deltas[3] = +1; + move_deltas[0] = +board_size; + move_deltas[1] = -board_size; + move_deltas[2] = -1; + move_deltas[3] = +1; } action_list_t *action_list_generate(void) { @@ -117,7 +108,7 @@ action_list_t *action_list_generate(void) { // Now we check for caps and walls const uint8_t cap_top = STONE_AT(loc) == STONE_CAPSTONE; for (int d = 0; d < 4; d++){ - const int delta = deltas[d]; + const int delta = move_deltas[d]; const int stop = end_stops[d]; end_stops[d] = 0; for (int k = 1; k <= stop; k++) { @@ -229,7 +220,7 @@ void action_take(const action_t action) { const uint8_t gaps = GET_DATA0(action) & 0x7F, num = GET_DATA1(action) & 0x0F, // unpack dir = GET_DATA1(action) >> 4; - int8_t delta = deltas[dir]; + int8_t delta = move_deltas[dir]; // Use the Kernighan method to count the set bits int8_t steps = 1; @@ -293,7 +284,7 @@ void action_undo(const action_t action) { crush = GET_DATA0(action) & 0x80, num = GET_DATA1(action) & 0x0F, dir = GET_DATA1(action) >> 4; - const int8_t delta = deltas[dir]; + const int8_t delta = move_deltas[dir]; int8_t steps = 1; uint8_t gap_bit = 1, total = 1; diff --git a/include/actions.h b/include/actions.h index 661f11e..d331284 100644 --- a/include/actions.h +++ b/include/actions.h @@ -10,6 +10,15 @@ enum A_TYPE { A_PLACE, A_MOVE }; typedef uint32_t action_t; +#define TYPE_SHIFT 24 +#define LOC_SHIFT 16 +#define DATA0_SHIFT 8 + +#define GET_TYPE(a) (enum A_TYPE)((a)>>TYPE_SHIFT) +#define GET_LOC(a) (int8_t)(((a)>>LOC_SHIFT) & 0xFF) +#define GET_DATA0(a) (uint8_t)(((a)>>DATA0_SHIFT) & 0xFF) +#define GET_DATA1(a) (uint8_t)((a) & 0xFF) + typedef struct action_node_s { struct action_node_s *next; action_t action; @@ -20,6 +29,8 @@ typedef struct action_list_s { uint32_t length; } action_list_t; +extern int8_t move_deltas[4]; + void action_list_init(void); void action_list_free(action_list_t *list); action_list_t *action_list_generate(void); diff --git a/include/zobrist.c b/include/zobrist.c new file mode 100644 index 0000000..8eeb758 --- /dev/null +++ b/include/zobrist.c @@ -0,0 +1,104 @@ +#include "zobrist.h" + +// =================================================================== +// Globals +// =================================================================== + +static uint64_t *zobrist[15]; + +// =================================================================== +// Helpers +// =================================================================== + + +// =================================================================== +// Exported method implementations +// =================================================================== + +int +zobrist_init(void) { + for (int k=0; k<15; k++) { + if (zobrist[k] != NULL) return EXIT_FAILURE; + } + + for (int j=0; j<15; j++) { + zobrist[j] = malloc(sizeof(uint64_t)*board_size*board_size*(2*3+1)); + for (int k=0; k>= 1) + hash ^= zobrist[h][l*(2*3+1)+(c&1)*3+s]; + } + return hash; +} + +uint64_t +zobrist_apply(const action_t action, uint64_t hash) { + const enum A_TYPE type = GET_TYPE(action); + const int8_t loc = GET_LOC(action); + if (type == A_PLACE) { + hash ^= zobrist[0][loc*(2*3+1) + +current_colour*3 + +GET_DATA0(action)]; + } else { + const uint8_t gaps = GET_DATA0(action) & 0x7F, + crush = GET_DATA0(action) & 0x80, + num = GET_DATA1(action) & 0x0F, + dir = GET_DATA1(action) >> 4; + const int8_t delta = move_deltas[dir]; + + // TODO: adapt this + int8_t steps = 1; + uint8_t gap_bit = 1, total = 1; + for (int8_t d = 1; d < num; d++, total++, gap_bit <<= 1) { + if (gaps & gap_bit) { + colours[loc] <<= total; + colours[loc] |= colours[loc+steps*delta] & ((1 << total) - 1); + colours[loc+steps*delta] >>= total; + celldat[loc] += total*NUM_INC; + celldat[loc+steps*delta] -= total*NUM_INC; + total = 0; + steps++; + } + } + colours[loc] <<= total; + colours[loc] |= colours[loc+steps*delta] & ((1 << total) - 1); + colours[loc+steps*delta] >>= total; + + celldat[loc] += total*NUM_INC; + // celldat[loc] &= CLR_STONE; is not necessary, as STONE_FLAT == 0 + celldat[loc] |= STONE_AT(loc+steps*delta); + celldat[loc+steps*delta] -= total*NUM_INC; + celldat[loc+steps*delta] &= CLR_STONE; + if (crush) { + celldat[loc+steps*delta] |= STONE_STANDING; + } else { + celldat[loc+steps*delta] |= STONE_FLAT; // should be optimised out + } + + } + return hash; +} diff --git a/include/zobrist.h b/include/zobrist.h new file mode 100644 index 0000000..4e760ca --- /dev/null +++ b/include/zobrist.h @@ -0,0 +1,15 @@ +#include +#include +#include + +void +zobrist_free(void); + +int +zobrist_init(void); + +uint64_t +zobrist_compute(void); + +uint64_t +zobrist_apply(const action_t action, uint64_t hash); -- cgit v1.2.3 From 8f15c1131342376ab3de2c6ce50d1ca5f20ec32a Mon Sep 17 00:00:00 2001 From: tslil clingman Date: Tue, 26 Jan 2021 23:54:46 -0500 Subject: I don't have the presence of mind to debug this right now --- include/negamax.c | 68 ++++++------------------------------------------- include/negamax.h | 2 ++ include/zobrist.c | 75 ++++++++++++++++++++++++++++++++++++++----------------- 3 files changed, 62 insertions(+), 83 deletions(-) diff --git a/include/negamax.c b/include/negamax.c index 061b629..b51961d 100644 --- a/include/negamax.c +++ b/include/negamax.c @@ -8,73 +8,14 @@ const float infty = 3.0; char negamax_ptn[9]; uint8_t negamax_search_depth = 3; -static uint64_t *zobrist[15]; - // =================================================================== // Helpers // =================================================================== -static void -zobrist_free(void); - -static int -zobrist_init(void); - -static uint64_t -zobrist_compute(void); - static float negamax(const uint8_t cur_depth, float alpha, float beta, const float colour); -// =================================================================== -// Zobrist hashing -// =================================================================== - -static uint64_t -zobrist_compute(void) { - uint64_t hash = 0; - for (uint8_t l=0; l>= 1; - } - } - } - return hash; -} - -static int -zobrist_init(void) { - for (int k=0; k<15; k++) { - if (zobrist[k] != NULL) return EXIT_FAILURE; - } - - for (int j=0; j<15; j++) { - zobrist[j] = malloc(sizeof(uint64_t)*board_size*board_size*(2*3+1)); - for (int k=0; k= breaks search stability - if (entry != NULL && entry->depth == cur_depth) { + if (entry != NULL && entry->depth >= cur_depth) { if (entry->flag == TT_EXACT) { return entry->value; } else if (entry->flag == TT_LOWERBOUND && entry->value > alpha) { @@ -145,6 +86,13 @@ negamax(const uint8_t cur_depth, float alpha, float beta, for (action_node_t *node=list->head; node!=NULL; node=node->next) { action_take(node->action); + + { + if (zobrist_apply(node->action, hash) != zobrist_compute()) { + printf("! %s\n", (GET_TYPE(node->action)==A_PLACE)?"A_PLACE":"A_MOVE"); + } + } + // Compute the value of the node float node_value; if (ply >= 2*board_size - 2 && (w = check_win()) < 0xFF) { diff --git a/include/negamax.h b/include/negamax.h index 43995d1..bba5af9 100644 --- a/include/negamax.h +++ b/include/negamax.h @@ -6,6 +6,7 @@ #include #include #include +#include extern const float infty; extern char negamax_ptn[9]; @@ -25,3 +26,4 @@ negamax_free(void); // negamax_display_progress function is called on every new square at // the top level. float negamax_generate(void); +extern uint8_t yes; diff --git a/include/zobrist.c b/include/zobrist.c index 8eeb758..6208339 100644 --- a/include/zobrist.c +++ b/include/zobrist.c @@ -60,8 +60,9 @@ zobrist_apply(const action_t action, uint64_t hash) { const enum A_TYPE type = GET_TYPE(action); const int8_t loc = GET_LOC(action); if (type == A_PLACE) { + enum COLOUR c = (current_colour == C_BLACK) ? C_WHITE : C_BLACK; hash ^= zobrist[0][loc*(2*3+1) - +current_colour*3 + +c*3 +GET_DATA0(action)]; } else { const uint8_t gaps = GET_DATA0(action) & 0x7F, @@ -70,35 +71,63 @@ zobrist_apply(const action_t action, uint64_t hash) { dir = GET_DATA1(action) >> 4; const int8_t delta = move_deltas[dir]; - // TODO: adapt this int8_t steps = 1; - uint8_t gap_bit = 1, total = 1; - for (int8_t d = 1; d < num; d++, total++, gap_bit <<= 1) { + uint8_t gap_bit = 1, num_dropped = 1, total = COUNT_AT(loc); + for (int8_t d = 1; d < num; d++, num_dropped++, gap_bit <<= 1) { if (gaps & gap_bit) { - colours[loc] <<= total; - colours[loc] |= colours[loc+steps*delta] & ((1 << total) - 1); - colours[loc+steps*delta] >>= total; - celldat[loc] += total*NUM_INC; - celldat[loc+steps*delta] -= total*NUM_INC; - total = 0; + const int8_t target = loc+steps*delta, th = COUNT_AT(target); + // Stash these stones to offset for the height at source + total += num_dropped; + // Apply XOR for stones at source and current target + uint8_t point = 1; + for (int k = 0, ht = th-1, hs = total-1; k < num_dropped; + k++, ht--, hs--, point<<=1) { + hash ^= zobrist[ht][target*(2*3+1) + +(point & colours[target])*3 + +STONE_FLAT]; + hash ^= zobrist[hs][loc*(2*3+1) + +(point & colours[target])*3 + +STONE_FLAT]; + } + // Continue processing gap sequence + num_dropped = 0; steps++; } } - colours[loc] <<= total; - colours[loc] |= colours[loc+steps*delta] & ((1 << total) - 1); - colours[loc+steps*delta] >>= total; - - celldat[loc] += total*NUM_INC; - // celldat[loc] &= CLR_STONE; is not necessary, as STONE_FLAT == 0 - celldat[loc] |= STONE_AT(loc+steps*delta); - celldat[loc+steps*delta] -= total*NUM_INC; - celldat[loc+steps*delta] &= CLR_STONE; + total += num_dropped; + const int8_t target = loc+steps*delta, th = COUNT_AT(target); + const enum STONE_VARIANT top_stone = STONE_AT(target); + // Stash these stones to offset for the height at source + // Apply XOR for stones at source and end target. After this + // source will be correct, but we must account for crush @ target. + uint8_t point = 1; + for (int k = 0, ht = th-1, hs = total-1; k < num_dropped; + k++, ht--, hs--, point<<=1) { + if (k == 0) { + hash ^= zobrist[ht][target*(2*3+1) + +(point & colours[target])*3 + +top_stone]; + hash ^= zobrist[hs][loc*(2*3+1) + +(point & colours[target])*3 + +top_stone]; + } else { + hash ^= zobrist[ht][target*(2*3+1) + +(point & colours[target])*3 + +STONE_FLAT]; + hash ^= zobrist[hs][loc*(2*3+1) + +(point & colours[target])*3 + +STONE_FLAT]; + } + } + // Correct for crush if (crush) { - celldat[loc+steps*delta] |= STONE_STANDING; - } else { - celldat[loc+steps*delta] |= STONE_FLAT; // should be optimised out + hash ^= zobrist[th-1][target*(2*3+1) + +(colours[target] & 1)*3 + +STONE_FLAT]; + hash ^= zobrist[th-1][target*(2*3+1) + +(colours[target] & 1)*3 + +STONE_STANDING]; } - } return hash; } -- cgit v1.2.3 From b5b337d4044a8e64956b8a2309739353f9ce339e Mon Sep 17 00:00:00 2001 From: tslil clingman Date: Thu, 28 Jan 2021 12:01:42 -0500 Subject: It would appear that any function call whatsoever is slower :/ For now we'll stay with directly recomputing it at each non-terminal node --- include/actions.c | 43 +++++++++++------------ include/actions.h | 20 ++++++----- include/negamax.c | 6 ---- include/zobrist.c | 103 ++++++------------------------------------------------ include/zobrist.h | 3 -- 5 files changed, 42 insertions(+), 133 deletions(-) diff --git a/include/actions.c b/include/actions.c index 96264d0..5085330 100644 --- a/include/actions.c +++ b/include/actions.c @@ -187,10 +187,10 @@ action_list_t *action_list_generate(void) { } void action_take(const action_t action) { - const int8_t loc = GET_LOC(action); - if (GET_TYPE(action) == A_PLACE) { + const int8_t loc = A_GET_LOC(action); + if (A_GET_TYPE(action) == A_PLACE) { const uint8_t black = (current_colour == C_BLACK); - switch (GET_DATA0(action)) { + switch (A_GET_DATA0(action)) { case STONE_FLAT: { if (black) black_count--; else white_count--; @@ -217,9 +217,9 @@ void action_take(const action_t action) { // not interested in whether we crushed, it will work out by // anyway because we overwrite the top stone type. See (*) later // for when we do need to know. - const uint8_t gaps = GET_DATA0(action) & 0x7F, - num = GET_DATA1(action) & 0x0F, // unpack - dir = GET_DATA1(action) >> 4; + const uint8_t gaps = A_GET_DATA0(action) & 0x7F, + num = A_GET_DATA1(action) & 0x0F, // unpack + dir = A_GET_DATA1(action) >> 4; int8_t delta = move_deltas[dir]; // Use the Kernighan method to count the set bits @@ -266,11 +266,11 @@ void action_undo(const action_t action) { // Previous ply inline_prev_ply(); - const int8_t loc = GET_LOC(action); - if (GET_TYPE(action) == A_PLACE) { + const int8_t loc = A_GET_LOC(action); + if (A_GET_TYPE(action) == A_PLACE) { const uint8_t black = (current_colour == C_BLACK); celldat[loc] = 0; - if (GET_DATA0(action) == STONE_CAPSTONE) { + if (A_GET_DATA0(action) == STONE_CAPSTONE) { if (black) black_count |= 0x80; else white_count |= 0x80; } else { @@ -280,10 +280,10 @@ void action_undo(const action_t action) { } else { // See action_take for comments, this is the time reversal, but // there is one caveat -- undoing a crush! (*) - const uint8_t gaps = GET_DATA0(action) & 0x7F, - crush = GET_DATA0(action) & 0x80, - num = GET_DATA1(action) & 0x0F, - dir = GET_DATA1(action) >> 4; + const uint8_t gaps = A_GET_DATA0(action) & 0x7F, + crush = A_GET_DATA0(action) & 0x80, + num = A_GET_DATA1(action) & 0x0F, + dir = A_GET_DATA1(action) >> 4; const int8_t delta = move_deltas[dir]; int8_t steps = 1; @@ -317,13 +317,13 @@ void action_undo(const action_t action) { } void action_to_ptn(const action_t action, char* out_ptn) { - const int8_t loc = GET_LOC(action); - if (GET_TYPE(action) == A_PLACE) { - generate_place(loc, GET_DATA0(action), out_ptn); + const int8_t loc = A_GET_LOC(action); + if (A_GET_TYPE(action) == A_PLACE) { + generate_place(loc, A_GET_DATA0(action), out_ptn); } else { - const uint8_t gaps = GET_DATA0(action) & 0x7F, - num = GET_DATA1(action) & 0x0F, // unpack - dir = GET_DATA1(action) >> 4; + const uint8_t gaps = A_GET_DATA0(action) & 0x7F, + num = A_GET_DATA1(action) & 0x0F, // unpack + dir = A_GET_DATA1(action) >> 4; uint8_t drops[board_size]; // we only ever need board_size-1 in // drops actually, the last spot is to @@ -356,10 +356,7 @@ list_append(action_list_t *list, const enum A_TYPE type, // TODO: trap errno new->next = NULL; - new->action = (type << TYPE_SHIFT) - | (loc << LOC_SHIFT) - | (data0 << DATA0_SHIFT) - | data1; + new->action = A_BUILD(type, loc, data0, data1); if (list->length) { list->tail->next = new; diff --git a/include/actions.h b/include/actions.h index d331284..ced0315 100644 --- a/include/actions.h +++ b/include/actions.h @@ -10,14 +10,18 @@ enum A_TYPE { A_PLACE, A_MOVE }; typedef uint32_t action_t; -#define TYPE_SHIFT 24 -#define LOC_SHIFT 16 -#define DATA0_SHIFT 8 - -#define GET_TYPE(a) (enum A_TYPE)((a)>>TYPE_SHIFT) -#define GET_LOC(a) (int8_t)(((a)>>LOC_SHIFT) & 0xFF) -#define GET_DATA0(a) (uint8_t)(((a)>>DATA0_SHIFT) & 0xFF) -#define GET_DATA1(a) (uint8_t)((a) & 0xFF) +#define A_TYPE_SHIFT 24 +#define A_LOC_SHIFT 16 +#define A_DATA0_SHIFT 8 + +#define A_GET_TYPE(a) (enum A_TYPE)((a)>>A_TYPE_SHIFT) +#define A_GET_LOC(a) (int8_t)(((a)>>A_LOC_SHIFT) & 0xFF) +#define A_GET_DATA0(a) (uint8_t)(((a)>>A_DATA0_SHIFT) & 0xFF) +#define A_GET_DATA1(a) (uint8_t)((a) & 0xFF) +#define A_BUILD(type,loc,data0,data1) ((type) << A_TYPE_SHIFT \ + | (loc) << A_LOC_SHIFT \ + | (data0) << A_DATA0_SHIFT \ + | (data1)) typedef struct action_node_s { struct action_node_s *next; diff --git a/include/negamax.c b/include/negamax.c index b51961d..cfe2643 100644 --- a/include/negamax.c +++ b/include/negamax.c @@ -87,12 +87,6 @@ negamax(const uint8_t cur_depth, float alpha, float beta, action_take(node->action); - { - if (zobrist_apply(node->action, hash) != zobrist_compute()) { - printf("! %s\n", (GET_TYPE(node->action)==A_PLACE)?"A_PLACE":"A_MOVE"); - } - } - // Compute the value of the node float node_value; if (ply >= 2*board_size - 2 && (w = check_win()) < 0xFF) { diff --git a/include/zobrist.c b/include/zobrist.c index 6208339..feff5fa 100644 --- a/include/zobrist.c +++ b/include/zobrist.c @@ -4,7 +4,7 @@ // Globals // =================================================================== -static uint64_t *zobrist[15]; +static uint64_t *zobrist; // =================================================================== // Helpers @@ -17,16 +17,12 @@ static uint64_t *zobrist[15]; int zobrist_init(void) { - for (int k=0; k<15; k++) { - if (zobrist[k] != NULL) return EXIT_FAILURE; - } + if (zobrist != NULL) return EXIT_FAILURE; - for (int j=0; j<15; j++) { - zobrist[j] = malloc(sizeof(uint64_t)*board_size*board_size*(2*3+1)); - for (int k=0; k>= 1) - hash ^= zobrist[h][l*(2*3+1)+(c&1)*3+s]; - } - return hash; -} - -uint64_t -zobrist_apply(const action_t action, uint64_t hash) { - const enum A_TYPE type = GET_TYPE(action); - const int8_t loc = GET_LOC(action); - if (type == A_PLACE) { - enum COLOUR c = (current_colour == C_BLACK) ? C_WHITE : C_BLACK; - hash ^= zobrist[0][loc*(2*3+1) - +c*3 - +GET_DATA0(action)]; - } else { - const uint8_t gaps = GET_DATA0(action) & 0x7F, - crush = GET_DATA0(action) & 0x80, - num = GET_DATA1(action) & 0x0F, - dir = GET_DATA1(action) >> 4; - const int8_t delta = move_deltas[dir]; - - int8_t steps = 1; - uint8_t gap_bit = 1, num_dropped = 1, total = COUNT_AT(loc); - for (int8_t d = 1; d < num; d++, num_dropped++, gap_bit <<= 1) { - if (gaps & gap_bit) { - const int8_t target = loc+steps*delta, th = COUNT_AT(target); - // Stash these stones to offset for the height at source - total += num_dropped; - // Apply XOR for stones at source and current target - uint8_t point = 1; - for (int k = 0, ht = th-1, hs = total-1; k < num_dropped; - k++, ht--, hs--, point<<=1) { - hash ^= zobrist[ht][target*(2*3+1) - +(point & colours[target])*3 - +STONE_FLAT]; - hash ^= zobrist[hs][loc*(2*3+1) - +(point & colours[target])*3 - +STONE_FLAT]; - } - // Continue processing gap sequence - num_dropped = 0; - steps++; - } - } - total += num_dropped; - const int8_t target = loc+steps*delta, th = COUNT_AT(target); - const enum STONE_VARIANT top_stone = STONE_AT(target); - // Stash these stones to offset for the height at source - // Apply XOR for stones at source and end target. After this - // source will be correct, but we must account for crush @ target. - uint8_t point = 1; - for (int k = 0, ht = th-1, hs = total-1; k < num_dropped; - k++, ht--, hs--, point<<=1) { - if (k == 0) { - hash ^= zobrist[ht][target*(2*3+1) - +(point & colours[target])*3 - +top_stone]; - hash ^= zobrist[hs][loc*(2*3+1) - +(point & colours[target])*3 - +top_stone]; - } else { - hash ^= zobrist[ht][target*(2*3+1) - +(point & colours[target])*3 - +STONE_FLAT]; - hash ^= zobrist[hs][loc*(2*3+1) - +(point & colours[target])*3 - +STONE_FLAT]; - } - } - // Correct for crush - if (crush) { - hash ^= zobrist[th-1][target*(2*3+1) - +(colours[target] & 1)*3 - +STONE_FLAT]; - hash ^= zobrist[th-1][target*(2*3+1) - +(colours[target] & 1)*3 - +STONE_STANDING]; - } + hash ^= zobrist[l*(15*2*3)+h*2*3+(c&1)*3+s]; } return hash; } diff --git a/include/zobrist.h b/include/zobrist.h index 4e760ca..cfc2941 100644 --- a/include/zobrist.h +++ b/include/zobrist.h @@ -10,6 +10,3 @@ zobrist_init(void); uint64_t zobrist_compute(void); - -uint64_t -zobrist_apply(const action_t action, uint64_t hash); -- cgit v1.2.3 From 1be9fac33c8227564079356c63840d227c88725f Mon Sep 17 00:00:00 2001 From: tslil clingman Date: Thu, 28 Jan 2021 13:53:19 -0500 Subject: Removed treap in favour of linked-list chained hash table --- include/negamax.h | 5 +- include/tt_llcht.c | 85 ++++++++++++++++++++++++++++ include/tt_llcht.h | 45 +++++++++++++++ include/tt_treap.c | 158 ----------------------------------------------------- include/tt_treap.h | 45 --------------- 5 files changed, 133 insertions(+), 205 deletions(-) create mode 100644 include/tt_llcht.c create mode 100644 include/tt_llcht.h delete mode 100644 include/tt_treap.c delete mode 100644 include/tt_treap.h diff --git a/include/negamax.h b/include/negamax.h index bba5af9..b41871e 100644 --- a/include/negamax.h +++ b/include/negamax.h @@ -2,10 +2,11 @@ #include #include + #include -#include #include -#include +#include +#include #include extern const float infty; diff --git a/include/tt_llcht.c b/include/tt_llcht.c new file mode 100644 index 0000000..03fa6cb --- /dev/null +++ b/include/tt_llcht.c @@ -0,0 +1,85 @@ +#include "tt_llcht.h" + +// =================================================================== +// Variables +// =================================================================== + +uint32_t tt_num_cached; +static tt_entry_t *table[TT_LLCHT_SIZE+1]; + +// =================================================================== +// Helper declarations +// =================================================================== + +tt_entry_t * +new_ll_node(const uint64_t key, const enum TT_FLAG flag, + const uint8_t depth, const float value, + const action_t action); + + +// =================================================================== +// Exported functions +// =================================================================== + +int tt_init(void) { + for (uint k=0; k<=TT_LLCHT_SIZE; k++) + table[k] = NULL; + return EXIT_SUCCESS; +} + +void tt_free(void) { + tt_entry_t *n, *nn; + for (uint k=0; k<=TT_LLCHT_SIZE; k++) { + n = table[k]; + while (n) { + nn = n->next; + free(n); + n = nn; + } + } +} + +tt_entry_t *tt_seek(const uint64_t key) { + tt_entry_t *lookup = table[key & TT_LLCHT_SIZE]; + while (lookup && lookup->key != key) + lookup = lookup->next; + return lookup; +} + +int tt_insert(const uint64_t key, const enum TT_FLAG flag, + const uint8_t depth, const float value, + const action_t action) { + tt_entry_t *new = new_ll_node(key, flag, depth, value, action), *n; + // TODO: trap + + const uint32_t idx = key & TT_LLCHT_SIZE; + if ((n = table[idx]) != NULL) { + for (; n->next != NULL; n = n->next); + n->next = new; + } else { + table[idx] = new; + } + + tt_num_cached++; + + return EXIT_SUCCESS; +} + +// =================================================================== +// Helper function implementations +// =================================================================== + +tt_entry_t * +new_ll_node(const uint64_t key, const enum TT_FLAG flag, + const uint8_t depth, const float value, + const action_t action) { + tt_entry_t *new = malloc(sizeof(struct tt_node_s)); + // TODO: trap errno + new->key = key; + new->next = NULL; + new->flag = flag; + new->depth = depth; + new->value = value; + new->action = action; + return new; +} diff --git a/include/tt_llcht.h b/include/tt_llcht.h new file mode 100644 index 0000000..f9a7a78 --- /dev/null +++ b/include/tt_llcht.h @@ -0,0 +1,45 @@ +#ifndef TT_LLCHT_H +#define TT_LLCHT_H + +#include +#include + +#include + +// =================================================================== +// Types +// =================================================================== + +enum TT_FLAG { TT_EXACT, TT_LOWERBOUND, TT_UPPERBOUND }; + +typedef struct tt_node_s { + uint64_t key; + struct tt_node_s *next; + enum TT_FLAG flag; + uint8_t depth; + float value; + action_t action; +} tt_entry_t; + +// =================================================================== +// Globals +// =================================================================== + +#define TT_LLCHT_SIZE ((uint32_t)((1<<19) - 1)) + +extern uint32_t tt_num_cached; + +// =================================================================== +// Methods +// =================================================================== + +int tt_init(void); +void tt_free(void); + +tt_entry_t *tt_seek(const uint64_t key); + +int tt_insert(const uint64_t key, const enum TT_FLAG flag, + const uint8_t depth, const float value, + const action_t action); + +#endif diff --git a/include/tt_treap.c b/include/tt_treap.c deleted file mode 100644 index 369d767..0000000 --- a/include/tt_treap.c +++ /dev/null @@ -1,158 +0,0 @@ -#include "tt_treap.h" - -// =================================================================== -// Variables -// =================================================================== - -uint32_t tt_num_cached; -static tt_entry_t * root; - -// =================================================================== -// Helper declarations -// =================================================================== - -void recurse_tree(tt_entry_t *n); -void bubble_up(tt_entry_t *n); - -tt_entry_t * -new_treap_node(const uint64_t key, const enum TT_FLAG flag, - const uint8_t depth, const float value, - const action_t action); - - -// =================================================================== -// Exported functions -// =================================================================== - -int tt_init(void) { - root = NULL; - tt_num_cached = 0; - return EXIT_SUCCESS; -} - -void tt_free(void) { - recurse_tree(root); - return; -} - -tt_entry_t *tt_seek(const uint64_t key) { - if (root == NULL) return NULL; - tt_entry_t * n = root; - - while (n != NULL && n->key != key) { - if (n->key > key) n = n->right; - else n = n->left; - } - return n; -} - -int tt_insert(const uint64_t key, const enum TT_FLAG flag, - const uint8_t depth, const float value, - const action_t action) { - tt_entry_t *m = new_treap_node(key, flag, depth, value, action); - if (root == NULL) { - root = m; - tt_num_cached = 1; - return EXIT_SUCCESS; - } - tt_entry_t *s = root, *n = root; - // Find the correct position by doing a BST traversal - while (n!=NULL) { - s = n; - if (n->key >= key) n = n->right; - else n = n->left; - } - // Make it a leaf - if (s->key > key) s->right = m; - else s->left = m; - m->parent = s; - // Now bubble upward to satisfy the heap property - bubble_up(m); - tt_num_cached++; - return EXIT_SUCCESS; -} - -// =================================================================== -// Helper implementations -// =================================================================== - -void recurse_tree(tt_entry_t *n) { - if (n==NULL) return; - if (n->left != NULL) recurse_tree(n->left); - if (n->right != NULL) recurse_tree(n->right); - free(n); -} - -tt_entry_t * -new_treap_node(const uint64_t key, const enum TT_FLAG flag, - const uint8_t depth, const float value, - const action_t action) { - tt_entry_t *n = malloc(sizeof(struct treap_node_s)); - // TODO: trap - n->key = key; - n->flag = flag; - n->depth = depth; - n->value = value; - n->left = NULL; - n->right = NULL; - n->parent = NULL; - n->action = action; - XORSHIFT64; n->weight = RANDOM32; - return n; -} - -void rotate_left(tt_entry_t *n) { - tt_entry_t *a = n->parent, *b = a->left, *c = n->left; - /* - We are the right child, so do this - a n - / \ / \ - b n --> a d - / \ / \ - c d b c - */ - n->parent = a->parent; - // We may have to repair one level up as well - if (a->parent!=NULL) { - if (a->parent->left == a) a->parent->left = n; - else a->parent->right = n; - } - a->parent = n; - n->left = a; a->parent = n; - a->left = b; if (b!=NULL) b->parent = a; - a->right = c; if (c!=NULL) c->parent = a; -} - -void rotate_right(tt_entry_t *n) { - tt_entry_t *a = n->parent, *b = a->right, *d = n->right; - /* - We are the left child, so do this - a n - / \ / \ - n b --> c a - / \ / \ - c d d b - */ - n->parent = a->parent; - // We may have to repair one level up as well - if (a->parent!=NULL) { - if (a->parent->left == a) a->parent->left = n; - else a->parent->right = n; - } - a->parent = n; - n->right = a; a->parent = n; - a->left = d; if (d!=NULL) d->parent = a; - a->right = b; if (b!=NULL) b->parent = a; -} - -//This preserves the BST quality of the treap -void bubble_up(tt_entry_t *n) { - // Nothing to be done in this case - if (n==NULL || n->parent == NULL) return; - // Bubble until the treap invariants are satisfied - while (n->parent != NULL && n->weight < n->parent->weight) { - if (n->parent->left == n) rotate_right(n); - else rotate_left(n); - } - if (n->parent == NULL) root = n; -} diff --git a/include/tt_treap.h b/include/tt_treap.h deleted file mode 100644 index 3991e79..0000000 --- a/include/tt_treap.h +++ /dev/null @@ -1,45 +0,0 @@ -#ifndef TT_TREAP_H -#define TT_TREAP_H - -#include -#include - -#include -#include - -// =================================================================== -// Types -// =================================================================== - -enum TT_FLAG { TT_EXACT, TT_LOWERBOUND, TT_UPPERBOUND }; - -typedef struct treap_node_s { - uint64_t key; - uint32_t weight; - struct treap_node_s *left, *right, *parent; - enum TT_FLAG flag; - uint8_t depth; - float value; - action_t action; -} tt_entry_t; - -// =================================================================== -// Globals -// =================================================================== - -extern uint32_t tt_num_cached; - -// =================================================================== -// Methods -// =================================================================== - -int tt_init(void); -void tt_free(void); - -tt_entry_t *tt_seek(uint64_t key); - -int tt_insert(const uint64_t key, const enum TT_FLAG flag, - const uint8_t depth, const float value, - const action_t action); - -#endif -- cgit v1.2.3